Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github-action group name #137

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

trmartin4
Copy link
Member

๐ŸŽŸ๏ธ Tracking

bitwarden.atlassian.net/browse/PM-14640

๐Ÿ“” Objective

Rename the group name to more clearly describe what dependencies are included.

This matches what has been done on clients and server:

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@trmartin4 trmartin4 requested a review from a team as a code owner January 15, 2025 20:31
Copy link

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ c98e2c9d-cd85-4802-9fa7-37d16decb70a

Great job, no security vulnerabilities found in this Pull Request

@trmartin4 trmartin4 merged commit 4829ed2 into main Jan 15, 2025
5 checks passed
@trmartin4 trmartin4 deleted the platform/pm-14640/update-group-name branch January 15, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants